Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rfc: add platform support RFC #1065

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

msanft
Copy link
Contributor

@msanft msanft commented Dec 12, 2024

This adds an RFC for platform support and representation in Contrast. This is in very much of a bare-bones stage now, so reviews and critique are welcome.

@msanft msanft added the no changelog PRs not listed in the release notes label Dec 12, 2024
@msanft msanft force-pushed the msanft/rfc/platform-support branch from 7459452 to 1650f8f Compare December 12, 2024 09:32
rfc/008-platform-support.md Show resolved Hide resolved
rfc/008-platform-support.md Show resolved Hide resolved
rfc/008-platform-support.md Outdated Show resolved Hide resolved
rfc/008-platform-support.md Outdated Show resolved Hide resolved
Copy link
Member

@thomasten thomasten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

General ideas LGTM, but I lack knowledge for some of the details.

tools/vale/styles/config/vocabularies/edgeless/accept.txt Outdated Show resolved Hide resolved
tools/vale/styles/config/vocabularies/edgeless/accept.txt Outdated Show resolved Hide resolved
rfc/008-platform-support.md Outdated Show resolved Hide resolved
rfc/008-platform-support.md Outdated Show resolved Hide resolved
rfc/008-platform-support.md Outdated Show resolved Hide resolved
rfc/008-platform-support.md Outdated Show resolved Hide resolved
rfc/008-platform-support.md Outdated Show resolved Hide resolved
rfc/008-platform-support.md Outdated Show resolved Hide resolved
tools/vale/styles/config/vocabularies/edgeless/accept.txt Outdated Show resolved Hide resolved
@katexochen katexochen added the needs: rework PR author needs to work in feedback label Dec 27, 2024
@msanft msanft force-pushed the msanft/rfc/platform-support branch 3 times, most recently from bf78446 to 8c5b1f4 Compare January 2, 2025 13:05
@msanft msanft requested review from katexochen and burgerdev January 2, 2025 13:05
This adds an RFC for platform support and representation in Contrast. This is in very much of a bare-bones stage now, so reviews and critique are welcome.
@msanft msanft force-pushed the msanft/rfc/platform-support branch from 8c5b1f4 to cbb0ee5 Compare January 2, 2025 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs: rework PR author needs to work in feedback no changelog PRs not listed in the release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants